feat: add slideout Footer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyTeterin
requested review from
Tonia-SE,
alexlatypov94,
blackymax,
Gurnick013 and
lbratkovskaya
src/components/Footer/Footer.tsx
Outdated
| return ( | ||
| <Typography> | ||
| <Link | ||
| href={`https://github.com/${author.githubName}`} |
There was a problem hiding this comment.
Можно префикс https://github.com/ вынести в константы вместе со списком данных авторов. Будет совсем красота))
Мотивация какая: мы максимально разделяем уровень данных и уровень представления
alexlatypov94
approved these changes
Mar 21, 2021
blackymax
approved these changes
Mar 21, 2021
lbratkovskaya
approved these changes
Mar 21, 2021
Gurnick013
approved these changes
Mar 21, 2021
Tonia-SE
approved these changes
Mar 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.