Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bar is very tall all of a sudden #60

Closed
rosefromthedead opened this issue Sep 20, 2024 · 11 comments
Closed

Bar is very tall all of a sudden #60

rosefromthedead opened this issue Sep 20, 2024 · 11 comments

Comments

@rosefromthedead
Copy link
Contributor

I have no idea what caused this or where to start looking for a fix, hopefully someone knows :P

@ldelossa
Copy link
Owner

I've seen this happen when gtk4-layer-shell becomes unavailable. Did you happen to remove, or do something to your system, which may have removed this shared library?

@rosefromthedead
Copy link
Contributor Author

No:

$ ldd way-shell | grep layer
	libgtk4-layer-shell.so.0 => /usr/lib/libgtk4-layer-shell.so.0 (0x00007fc14e1fe000)

I ran gtk4-layer-demo and it looks normal..

@ldelossa
Copy link
Owner

Odd, can you dump the logs from stdout into a text file and share?

@rosefromthedead
Copy link
Contributor Author

way-shell.log
here's me opening it from main and ^C'ing shortly after

I should say, this doesn't seem to be because of a change in way-shell; old and new versions are all misbehaving in the same way

@rosefromthedead
Copy link
Contributor Author

There was a gtk4-layer-shell update in Arch recently, but downgrading to the previous version didn't fix it. Neither did downgrading gtk4 :(

@ldelossa
Copy link
Owner

Are you building locally or using a package manager?

@rosefromthedead
Copy link
Contributor Author

Building locally with make && ./way-shell

@ldelossa
Copy link
Owner

Try a "make clean && git clean -xdf" and build again, maybe something some old objects are laying around

@rosefromthedead
Copy link
Contributor Author

rosefromthedead commented Sep 21, 2024

Nope, same stuff. I tried installing the latest schema xml in /usr/... and rebuilding the schema for good measure but no luck there either. FWIW I have an old copy of way-shell from the AUR installed in /usr/ and that has the same problem.

(would you accept a patch to switch to e.g. meson?)

@rosefromthedead
Copy link
Contributor Author

My friend, also on Arch, can reproduce. My Fedora machine does not have the problem, with way-shell installed from copr

@Foxinatel
Copy link

Seems to be an issue with libadwaita 1.6, which is causing the height-request property of the panel to be set to 200. Downgrading libadwaita to 1.5.4 returns behavior to normal.

rosefromthedead added a commit to rosefromthedead/way-shell that referenced this issue Sep 22, 2024
A change in libadwaita 1.6 (7a705c79) makes our old code spawn a huge
panel. Adjust ourselves to override libadwaita's default 360x200 size and
make the panel reasonable again.

Tested to still work on libadwaita 1.5, too.

Fixes ldelossa#60
Co-authored-by: Nathaniel Mason <nathanielma5on@yahoo.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants