Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(Makefile): add to existing flags instead of overwriting #22

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Jun 10, 2024

Some build environments set LDFLAGS and CFLAGS - the build system should respect those and add to them.

Some build environments set LDFLAGS and CFLAGS - the build system should
respect those and add to them.
@b1rger b1rger force-pushed the birger/use-cflags-and-ldflags branch from 0c2302c to b679bed Compare June 10, 2024 18:44
Copy link
Owner

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you!

@ldelossa ldelossa merged commit 51801c0 into ldelossa:main Jun 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants