fix,wifi: allow connecting to WPA AP's with no password #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit there was a misunderstanding in how to identity WIFI APs without password protection. The nm_access_point_get_wpa_flags and nm_access_point_get_rsn_flags should be used instead of the general nm_access_point_get_flags flags. This is because an AP can still advertise WPA abilities without having a password enabled. We actually don't care too much about the 'general' abilities of an AP, so just check the security related flags. Signed-off-by: ldelossa <louis.delos@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit there was a misunderstanding in how to identity WIFI APs without password protection.
The nm_access_point_get_wpa_flags and nm_access_point_get_rsn_flags should be used instead of the general nm_access_point_get_flags flags.
This is because an AP can still advertise WPA abilities without having a password enabled.
We actually don't care too much about the 'general' abilities of an AP, so just check the security related flags.