[experimental] status notifier infra #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldelossa
force-pushed
the
status-notifier
branch
from
4cb54b5 to
aab9221
Compare
- Add the necessary DBUS services for org.kde.StatusNotifier - Send signals for dbus session name creation/removal - CRUD on org.kde.StatusNotifierItem via aforementioned Dbus signals and notifier infra - new IndicatorBar to list SNI buttons in the panel
ldelossa
force-pushed
the
status-notifier
branch
from
aab9221 to
38d69d1
Compare
This commit adds the necessary functions for an initially useable DBUSMENU. It's not the best implementation, for instance, we just completely replace menu models when an update for the Menu comes up. This works decently well tho, at least for nm-applet which I'm testing with. Signed-off-by: ldelossa <louis.delos@gmail.com>
After some experimentation: - Crashes can be avoided when swapping out a newly updated GMenuModel into the GtkPopoverMenu by using the correct API (who would have guessed). Signed-off-by: ldelossa <louis.delos@gmail.com>
Signed-off-by: ldelossa <louis.delos@gmail.com>
Signed-off-by: ldelossa <louis.delos@gmail.com>
ldelossa
force-pushed
the
status-notifier
branch
from
45ded1d to
3fa16d2
Compare
The StatusNotifierItem DBus signals seem to be detached from actually updating the cooresponding proxy's values. It therefore became necessary to init the StatusNotifierItem with values gained from the proxy attributes, but then perform a GetAll properties call on the proxy when we receive a signal from the StatusNotifierItem interface. This commit handles this two-truths scenario, where we first init from cached proxy attributes, then query DBus on signals Signed-off-by: ldelossa <louis.delos@gmail.com>
ldelossa
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests implements experiment StatusNotifier support (Tray Icons).
The implementation leans on GtkPopover to display menus.
This comes with some opinions on how menu should be displayed in Gtk4.
Mostly:
It is possible to circumvent these, err limitations?, with a custom widget, but the MVP of this feature doesn't do this.
The DBusMenu API is parsed into a GMenuModel. AFAIKT there's not many libraries which do this, and its hand-rolled, so please draw my attention to apps which cause an issue.
Current limitations: