Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

consolidate building position checks #10389

Merged
merged 2 commits into from
Nov 3, 2024
Merged

consolidate building position checks #10389

merged 2 commits into from
Nov 3, 2024

Conversation

Raycoms
Copy link
Contributor

@Raycoms Raycoms commented Nov 1, 2024 •
edited
Loading

Closes #
Closes #

Changes proposed in this pull request

  • Consolidate building position checks and reorganize where this is called from
  • Remove this from the vanilla override which is used for very different usecases
  • Return by default a pos offset by 1 which is standable

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@Raycoms Raycoms merged commit a74c8a9 into version/main Nov 3, 2024
5 checks passed
@Raycoms Raycoms deleted the building-pos-reorg branch November 3, 2024 15:49
Raycoms added a commit that referenced this pull request Nov 4, 2024
@Raycoms
consolidate building position checks (#10389)
a2bd611 
Consolidate building position checks and reorganize where this is called from
Remove this from the vanilla override which is used for very different usecases
Return by default a pos offset by 1 which is standable
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@someaddons someaddons someaddons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Raycoms @someaddons