Dontcrash #10525
Merged
Dontcrash #10525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someaddons
reviewed
Dec 11, 2024
| @@ -59,7 +60,7 @@ public AbstractCrafting(@NotNull final ItemStack stack, final int count, final i | |||
|
|
|||
| if (ItemStackUtils.isEmpty(stack)) | |||
| { | |||
| throw new IllegalArgumentException("Cannot deliver Empty Stack."); | |||
| Log.getLogger().error("Created Empty Stack", new Exception()); | |||
There was a problem hiding this comment.
should return here to prevent setting the size on the empty staack below
someaddons
approved these changes
Dec 11, 2024
Raycoms
added a commit
that referenced
this pull request
Dec 23, 2024
Dont crash with empty stack, but log error so we can find origin more easily. Better log spam than exceptions
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Changes proposed in this pull request
Testing
Review please