move soundsource, prob fixes 10644 #10645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someaddons
reviewed
Feb 9, 2025
| @@ -292,7 +291,7 @@ private EatingState goToEatingPlace() | |||
| } | |||
| } | |||
|
|
|||
| if (EntityNavigationUtils.walkToPos(citizen, eatPos, 2, true)) | |||
| if (citizen.getVehicle() != null || EntityNavigationUtils.walkToPos(citizen, eatPos, 2, true)) | |||
There was a problem hiding this comment.
this shouldnt be needed, if it is then another logic is failing, an it creates a new sitting entity for the citizen that is sitting already
There was a problem hiding this comment.
The citizen end up in a sit/stand loop because walkToPos resets the sitting position
someaddons
approved these changes
Feb 9, 2025
Raycoms
added a commit
that referenced
this pull request
Feb 9, 2025
Move soundsource of raid source to hostile Fix concrete mixer issue Remove extra food handout Fix standup/sitdown loop at restaurant
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10644
Closes #10646
Changes proposed in this pull request
Testing
Review please