Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix deco controller rotation & display #10656

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

uecasm
Copy link
Contributor

@uecasm uecasm commented Feb 14, 2025

Closes discord request

Changes proposed in this pull request

  • Make decoration controllers use the same "refer to blueprint" method as huts to determine relative rotation (fixes rotation bugs if not scanned at 0 rotation).
  • Removes some redundant NBT values from decoration controllers.
  • Adjusts deco controller UI to make blueprint path more readable.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please (probably port)

One alternative to this would be to just set the stored rotation to 0 on scan, but that's actually harder to arrange since there isn't a good hook in Structurize that isn't called at other times. And this avoids having to re-scan existing blueprints.

@Raycoms Raycoms merged commit 2c0b870 into version/main Feb 15, 2025
5 checks passed
@Raycoms Raycoms deleted the fix/deco-controller branch February 15, 2025 13:34
uecasm added a commit that referenced this pull request Feb 16, 2025
@uecasm uecasm mentioned this pull request Feb 16, 2025
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants