Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix double feeding confusion #9784

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Fix double feeding confusion #9784

merged 3 commits into from
Feb 18, 2024

Conversation

someaddons
Copy link
Contributor

Closes #
Closes #
Closes #

Changes proposed in this pull request:

  • Add statistics to herders
  • Merge feeding children and normal feeding

[x ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

Review please

Merge feeding children and normal feeding
@MotionlessTrain
Copy link
Contributor

Does that mean that if you enable breeding, that baby animals are also fed automatically?
(I like to have breeding on, but feeding off myself)

@Thodor12
Copy link
Contributor

Thodor12 commented Feb 15, 2024

Does that mean that if you enable breeding, that baby animals are also fed automatically? (I like to have breeding on, but feeding off myself)

Feeding setting is gone, the herder will now always feed all animals, including children. If a child gets fed, it will trigger the aging process. However unlike the previous feeding children implementation, feeding children is not a continuous action, it will run on the same timeout as the current feeding system does, which also reduces the amount of food that is required by a bit if feeding were on.
If feeding were off it'd slightly increase food amount, but not by much (children could still be fed by the regular feed mechanic)

Breeding is pretty much untouched.

@someaddons
Copy link
Contributor Author

since we currently have non optional interval feeding, I'm dropping the optional child feeding and allowing the already existing feeding to also feed the child

@uecasm
Copy link
Contributor

uecasm commented Feb 16, 2024

I'd prefer if child feeding were still a setting, because I always want it to be off. I'd rather just wait the time instead of spending the food.

@someaddons
Copy link
Contributor Author

someaddons commented Feb 16, 2024

with this change it does not cost any food, like this literally removes the setting and the food cost overhead

@Thodor12
Copy link
Contributor

Children would be fed with the daily feeding cost anyway, on top of what they would get fed with the separate child feeding system. So this would only remove excess wheat and clear out the confusion in the UI regarding what "feeding" does.

@MotionlessTrain
Copy link
Contributor

Children would be fed with the daily feeding cost anyway, on top of what they would get fed with the separate child feeding system. So this would only remove excess wheat and clear out the confusion in the UI regarding what "feeding" does.

Don't they just feed to breed anymore? Is it now using a custom way to breed?
That was what the wheat initially was for, to feed just the adults to invoke the default breeding mechanic. The force feeding of baby animals was added later as extra thing for impatient colony owners who happen to have a backlog of wheat.
Not sure whether it makes sense to always feed the baby animals now (even in the daily routine), unless feeding animals isn't doing anything (just implemented for lore reasons), and the breeding uses a custom behaviour

@Raycoms Raycoms merged commit 4580840 into version/main Feb 18, 2024
2 checks passed
@Raycoms Raycoms deleted the feeding branch February 18, 2024 13:11
Raycoms pushed a commit that referenced this pull request Mar 24, 2024
Add statistics to herders
Merge feeding children and normal feeding
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants