Fix armor level checking #9786
Merged
Fix armor level checking #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightenom
reviewed
Feb 17, 2024
| /** | ||
| * Implementation for the IArmorMaterial interface so we can add custom armor types. | ||
| * Implementation for the ArmorMaterial interface, so we can add custom armor types. | ||
| */ | ||
| public class MineColoniesArmorMaterial implements ArmorMaterial |
There was a problem hiding this comment.
just side question: side you edit this class anyway how about making it true record?
There was a problem hiding this comment.
I prefer to not hide code :D
There was a problem hiding this comment.
My intention was to leave it the same implementation as the ArmorMaterials enum so it's easy to spot differences.
Nightenom
reviewed
Feb 17, 2024
src/main/java/com/minecolonies/core/items/MineColoniesArmorMaterial.java
Outdated
Show resolved
Hide resolved
Raycoms
approved these changes
Feb 25, 2024
someaddons
approved these changes
Feb 25, 2024
Raycoms
pushed a commit
that referenced
this pull request
Mar 24, 2024
When checking for armor level, the entire armor set + toughness is taken into consideration as opposed to only the armor level of the chestplate. Fixed the MinecoloniesArmorMaterial to updated ArmorMaterials Mojang implementation, so that armor values are applied in the correct order to each armor type. Updated plate armor: Durability raised from 20 to 37 Armor levels updated from 4,9,7,4 to 3,8,6,3 (helmet, chestplate, leggings, boots) Toughness reduced from 2 to 0 Enchantment level raised from 6 to 9 Updated pirates armors: Pirate armor 1 is now identical to iron with durability of diamond Pirate armor 2 is now identical to diamond with durability of iron Fixed other armors in the mod to use the new armor material constructor (santa hat and build goggles)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
[X] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.
Review please