Move quests to colony/quests #9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this work correctly in existing worlds? |
points at the not-ticked "tested" checkbox But yes, it should, the quest ids are relative so changing the base path doesn't change them. |
|
It will break any existing addon quest datapacks, but I don't think there are currently any of those yet. |
Raycoms
approved these changes
Mar 24, 2024
someaddons
approved these changes
Mar 27, 2024
Raycoms
pushed a commit
that referenced
this pull request
Mar 27, 2024
Moves quests to colony/quests dir
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes incompatibility with pixelmon
Changes proposed in this pull request:
colony/questsdir[ ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.
Review please (could backport)