Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/underwater raiders #9899

Merged
merged 13 commits into from
Apr 14, 2024
Merged

Feature/underwater raiders #9899

merged 13 commits into from
Apr 14, 2024

Conversation

Raycoms
Copy link
Contributor

@Raycoms Raycoms commented Apr 7, 2024

Closes #
Closes #
Closes #

Changes proposed in this pull request:

  • Create new underwater raider type, that spawns in sunken pirate ships

[ x ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

I still need to adjust the schematics of the ships and the spawn height requirements

Review please

@Raycoms Raycoms marked this pull request as ready for review April 7, 2024 14:18

if (soundevent != null && level().random.nextInt(OUT_OF_ONE_HUNDRED) <= ONE)
{
this.playSound(soundevent, this.getSoundVolume(), this.getVoicePitch());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to do normal sounds while under water? maybe check head for waterblock and just play drowned zombie noise?

someaddons
someaddons previously approved these changes Apr 14, 2024
@Raycoms Raycoms merged commit 96753b8 into version/main Apr 14, 2024
1 check passed
@Raycoms Raycoms deleted the feature/underwater-raiders branch April 14, 2024 14:08
Raycoms added a commit that referenced this pull request Apr 21, 2024
Create new underwater raider type, that spawns in sunken pirate ships
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants