-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature/underwater raiders #9899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someaddons
reviewed
Apr 14, 2024
|
||
if (soundevent != null && level().random.nextInt(OUT_OF_ONE_HUNDRED) <= ONE) | ||
{ | ||
this.playSound(soundevent, this.getSoundVolume(), this.getVoicePitch()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to do normal sounds while under water? maybe check head for waterblock and just play drowned zombie noise?
someaddons
previously approved these changes
Apr 14, 2024
Raycoms
added a commit
that referenced
this pull request
Apr 21, 2024
Create new underwater raider type, that spawns in sunken pirate ships
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Closes #
Changes proposed in this pull request:
[ x ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.
I still need to adjust the schematics of the ships and the spawn height requirements
Review please