Only hit at line of sight #9966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someaddons
reviewed
May 29, 2024
| @@ -111,7 +114,8 @@ private IAIState selectTarget() | |||
| return DECIDE; | |||
| } | |||
| final BlockPos targetPos = archeryBuilding.getRandomShootingTarget(worker.getRandom()); | |||
| if (targetPos == null) | |||
| if (targetPos == null || !WorldUtil.isBlockLoaded(world, targetPos) || | |||
| !world.clip(new ClipContext(new Vec3(worker.getX(), worker.getEyeY(), worker.getZ()), new Vec3(targetPos.getX() + HALF_BLOCK, targetPos.getY() + HALF_BLOCK, targetPos.getZ() + HALF_BLOCK), ClipContext.Block.COLLIDER, net.minecraft.world.level.ClipContext.Fluid.NONE, worker)).getBlockPos().equals(targetPos)) | |||
There was a problem hiding this comment.
make sure to test it with different target blocks, it may be depending on the target shape that the check fails
There was a problem hiding this comment.
We only use full block target blocks here
There was a problem hiding this comment.
oh ok thought we had added tags
There was a problem hiding this comment.
for the shooting position only
someaddons
approved these changes
May 29, 2024
Raycoms
added a commit
that referenced
this pull request
Jul 27, 2024
Make Archer Trainees only shoot if there is a line of sight
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Closes #
Changes proposed in this pull request:
[ x ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.
Review please