Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve builder building positions #9981

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Improve builder building positions #9981

merged 1 commit into from
Jun 10, 2024

Conversation

someaddons
Copy link
Contributor

Closes #
Closes #
Closes #

Changes proposed in this pull request:

  • Prevent builder from standing where hes mining below
  • Prevent builder from dropping down when searching for a building position
  • Add strong preference for standing outside of water while building

[x ] Yes I tested this before submitting it.
[ ] I also did a multiplayer test.

Review please

Prevent builder from dropping down when searching for a building position
Add strong preference for standing outside of water while building
@@ -56,6 +57,11 @@ protected double computeHeuristic(final int x, final int y, final int z)
@Override
protected boolean isAtDestination(@NotNull final MNode n)
{
if (desiredPosition.getX() == n.x && desiredPosition.getZ() == n.z)
{
return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm, its only for the close to task

@Raycoms Raycoms merged commit b5be09c into version/main Jun 10, 2024
2 checks passed
@Raycoms Raycoms deleted the builderposfixes branch June 10, 2024 08:31
Raycoms pushed a commit that referenced this pull request Jul 27, 2024
Prevent builder from standing where hes mining below
Prevent builder from dropping down when searching for a building position
Add strong preference for standing outside of water while building
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants