Tolerate leading zeros in numeric color parameters #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just published v1.6.1. Many thanks again 🙏 |
|
No problem! Thanks for accepting the change.
…On Thu, Jun 8, 2023 at 9:01 PM Lea Anthony ***@***.***> wrote:
I've just published v1.6.1. Many thanks again 🙏
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH6PVQOCQVVFDOIPGA5SQTXKJYWTANCNFSM6AAAAAAY7LC5MI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows leading zeros in parameters. I.e. it will accept
ESC [032mas if it wereESC [32m.This is mostly to support https://github.com/aybabtme/rgbterm which uses the sequence
ESC [0;00mto reset the terminal colors to default:https://github.com/aybabtme/rgbterm/blob/cc83f3b3ce5911279513a46d6d3316d67bedaa54/rgbterm.go#L36
Really, the change could just as easily be made in rgbterm. But it seems like most terminals support having that leading zero (since rgbterm works in them), so it's likely that leading zeros would show up in other places like other colorizing implementations or people's scripts.