Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement caching for on-demand compiling with plessc #513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thybzi
Copy link

@thybzi thybzi commented Dec 3, 2013

Implemented caching feature (that exists in main module) to plessc command-line tool.
Added -q key to plessc in order to enable this new feature.

The code if based on this example from lessphp documentation:
http://leafo.net/lessphp/docs/#compiling_automatically

Generates .lessphp files beside corresponded less-files compiled, and then tries to read them and use as cache.
Rewrites cache files when needed ($cache_new["updated"] > $cache["updated"]).

@thybzi
Copy link
Author

thybzi commented Dec 7, 2013

This thing about caching is what we are using intensively in a project with lot of LESS styles compiled with lessphp.

Please accept this request, or explain problems/issues it can cause (though I can't imagine any - because it is a new feature, changing nothing in existing functional :)

I suppose this feature could be useful for everyone who uses lessphp.

@thybzi
Copy link
Author

thybzi commented Dec 14, 2013

Please merge this pull request, I think this feature will be useful for everyone using plessc CLI tool. Also, it shouldn't break anything currently working.

@thybzi
Copy link
Author

thybzi commented Dec 22, 2013

Would you please (review and) merge that?

@thybzi
Copy link
Author

thybzi commented Jan 18, 2014

Why don't accept this cool pull request?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants