Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support additional headers #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnd0e
Copy link
Contributor

@johnd0e johnd0e commented Apr 5, 2024

No description provided.

@leafo
Copy link
Owner

leafo commented Apr 5, 2024

Could you explain more about why you want this, and why it should be something stored on the client instance?

Thanks

@johnd0e
Copy link
Contributor Author

johnd0e commented Apr 5, 2024

Sure.
For example OpenAI-Organization.
And there are some 3rd-party services, that are not exactly openai-compatible, and require extra headers to pass additional info.
E.g. see https://docs.helicone.ai/getting-started/integration-method/openai-proxy

@leafo
Copy link
Owner

leafo commented Apr 17, 2024

Thanks for the contribution. My only suggestion is that the more_headers argument takes precedence over the instance level headers object, meaning it's merged after the headers object

@johnd0e johnd0e mentioned this pull request Apr 17, 2024
@johnd0e johnd0e force-pushed the additional-headers branch from bbce101 to 3c82d66 Compare April 17, 2024 15:29
@johnd0e
Copy link
Contributor Author

johnd0e commented Apr 17, 2024

My only suggestion is [...]

Sure. Done

@johnd0e johnd0e force-pushed the additional-headers branch from 3c82d66 to 5a1d613 Compare April 17, 2024 22:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants