KImg review follow-ups

[MisRob]

Description

(1) Removes props related to dimensions

These can be simply set by native CSS, with the benefits of

• no need for validation
• no need to be adding support for new units
• no need to have the whole section in the docs to explain how to use something that is, in its native form, familiar to every developer

Even though this is a breaking change, I think it's better to do it sooner than later since at this point, KImg is not used in the products.

(2) Improves internal classes naming

The previous naming didn't make much sense. For example, scaleStyles.innerContainer communicates its purpose (styles related to scaling logic applied to the inner container) much clearly than previous scaleStyles.ratioContainer.

Issue addressed

This resolves some feedback on my KImg work from the walkthrough we did with @AllanOXDi.

Changelog

• #615
  • Description: Removes KImg props related to dimensions: height, width, maxHeight, minHeight, maxWidth, minWidth
  • Products impact: updated API
  • Addresses: -
  • Components: KImg
  • Breaking: yes
  • Impacts a11y: no
  • Guidance: Use native style, for example replace <KImg width="100%" maxWidth="500px" /> by <KImg :style="{ width: '100%', maxWidth: '500px' }" />.

• #615
  • Description: Renames KImg internal classes
  • Products impact: none
  • Addresses: -
  • Components: KImg
  • Breaking: -
  • Impacts a11y: -
  • Guidance: -

Steps to test

• Does code make sense?
• Do documentation examples works as before?

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical and brittle code paths are covered by unit tests
• The change is described in the changelog section above

Reviewer guidance

• Is the code clean and well-commented?
• Are there tests for this change?
• Are all UI components LTR and RTL compliant (if applicable)?
• Add other things to check for here

After review

• The changelog item has been pasted to the CHANGELOG.md

Comments

[akolson]

These changes look correct and make sense to me. Thanks @MisRob @AllanOXDi for this. Also, the names for the scaleType internals also are now much more clearer. <3

[MisRob]

Hi, thanks