Make KRadioButton to show a warning for developers when it's not nested inside KRadioButtonGroup #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michaela Robosova <robosovam@gmail.com>
…ed inside KRadioButtonGroup
revert changes made to KModal and remove KFocustrap for the time being
AlexVelezLl
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Thank you @lokesh-sagi125! Code looks good to me, and it seems we are not having a big impact in the performance. Well done!
|
thank you @AlexVelezLl looking forward to contribute more:). |
4 tasks
KshitijThareja
pushed a commit
to KshitijThareja/kolibri-design-system
that referenced
this pull request
Dec 17, 2024
…ed inside KRadioButtonGroup (learningequality#781)
KshitijThareja
pushed a commit
to KshitijThareja/kolibri-design-system
that referenced
this pull request
Dec 17, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add logic to the KRadioButton to make sure it is nested i the KRadioButtonGroup
Issue addressed
Make KRadioButton to show a warning for developers when it's not nested inside KRadioButtonGroup #761
Addresses #761
Before/after screenshots
Changelog
KRadioButtonto show a warning for developers when it's not nested insideKRadioButtonGroup#761