Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use notify_team_new_comment workflow action from .github repo #849

Conversation

rparadowski
Copy link
Contributor

Description

With learningequality/.github#11
reusable action is added to .github repo. This PR makes use of it.

Issue addressed

Issue: learningequality/kolibri#12567

Addresses learningequality/.github#11

Changelog

  • Description: A Reusable action is added to .github repo. This PR makes use of it.
  • Products impact: none
  • Addresses: -
  • Components: -
  • Breaking: -
  • Impacts a11y: -
  • Guidance: -

Steps to test

Create Pull request similar to learningequality/test-actions#53
Create issue and link it to PR
Change default repo branch to the branch you are changing in PR from (1.) due to https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment
Post comment in issue.

(optional) Implementation notes

At a high level, how did you implement this?

Does this introduce any tech-debt items?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

Comments

@rtibbles rtibbles merged commit 91129bc into learningequality:develop Dec 11, 2024
8 checks passed
learning-equality-bot bot pushed a commit that referenced this pull request Dec 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants