-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade morango, cryptography and dependency versions. #10824
Upgrade morango, cryptography and dependency versions. #10824
Conversation
Build Artifacts
|
Looks like I'm going to have to do some tweaks to properly handle C extension installation now. Will do some more work on this. |
638041e
to
fc64399
Compare
Our C extension downloading code appears to be unfamiliar with some of the new fangled wheel file names on PyPi these days, so is breaking. |
fc64399
to
e5a8abf
Compare
Have confirmed that this allows Windows to be properly tested on Python 3.8, which is very positive! Reverting that change, and now attempting to fix the build issue. If I can get that working, we can release a new v0.7.x version of morango to make this mergerable. |
…alls is installed.
all supported Python versions.
e5a8abf
to
6b9959c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the morango integration tests 👍
Tested on Windows 7, 10 and 11 without noticing new issues with the installer or change in the CPU usage which is fluctuating and is the same as reported in #11622. |
Summary
Reviewer guidance
Hopefully ameliorates #9908
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)