Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade morango, cryptography and dependency versions. #10824

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 9, 2023

Summary

  • Upgrades morango to version that is tested against newer version of cryptography library and that drops support for Python 3.4 and 3.5
  • Upgrades cryptography and its dependencies to the latest version supported by Python 2.7
  • Updates C extension bundling to ensure that we properly bundle for all supported Python 3 versions
  • Updates C extension bundling to ensure that we bundle for Python 3.8 on Windows
  • Updates tox tests to run on Python 3.8 on Windows

Reviewer guidance

Hopefully ameliorates #9908


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles
Copy link
Member Author

rtibbles commented Jun 9, 2023

Looks like I'm going to have to do some tweaks to properly handle C extension installation now. Will do some more work on this.

@rtibbles
Copy link
Member Author

Our C extension downloading code appears to be unfamiliar with some of the new fangled wheel file names on PyPi these days, so is breaking.

@rtibbles rtibbles changed the base branch from develop to release-v0.16.x December 12, 2023 19:07
@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Dec 12, 2023
@rtibbles
Copy link
Member Author

Have confirmed that this allows Windows to be properly tested on Python 3.8, which is very positive! Reverting that change, and now attempting to fix the build issue. If I can get that working, we can release a new v0.7.x version of morango to make this mergerable.

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Dec 13, 2023
@rtibbles rtibbles marked this pull request as ready for review December 13, 2023 21:41
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the morango integration tests 👍

@bjester bjester merged commit dd51643 into learningequality:release-v0.16.x Dec 13, 2023
33 checks passed
@pcenov
Copy link
Member

pcenov commented Dec 14, 2023

Tested on Windows 7, 10 and 11 without noticing new issues with the installer or change in the CPU usage which is fluctuating and is the same as reported in #11622.

@rtibbles rtibbles deleted the upgrade_morango branch December 29, 2023 19:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment SIZE: small SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants