Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes retry_in behaviour. Adds tests. #11023

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 27, 2023

Summary

  • Allows args and kwargs to be updated on already created jobs
  • Properly updates repeat and interval values when using the retry_in Job method and retry_job_in Storage method
  • Adds the tests for this behaviour that I should have added in the first place
  • Does some small refactor within the Storage _update_job method, in order to prevent complexity linting errors

References

Fixes an issue that became very apparent during a bug bash

Fixes #11046

Reviewer guidance

Ensure that single user syncing is properly repeating


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 27, 2023
@rtibbles rtibbles requested a review from bjester July 27, 2023 20:29
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Jul 27, 2023
@rtibbles rtibbles changed the base branch from develop to release-v0.16.x August 2, 2023 19:10
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after walk-through review with @rtibbles. @radinamatic - we will tag the beta tomorrow for the session and this will be ready to test on the APK to see if the syncing is working as expected there.

@marcellamaki marcellamaki merged commit fe74f37 into learningequality:release-v0.16.x Aug 3, 2023
@rtibbles rtibbles deleted the allow_repeat_and_interval_editing branch August 3, 2023 17:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: medium TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requeuing a LOD sync job fails updating keys ‘repeat’ and ‘interval’
2 participants