Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update SQLAlchemy to latest Python 2.7 compatible version #11091

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

rtibbles
Copy link
Member

Summary

  • Ceci n'est pas un dependabot
  • I thought this upgrade might help import performance of SQLAlchemy, but it did not - but worth having for bug fixes anway.

References

Changelog: https://github.com/sqlalchemy/sqlalchemy/blob/main/doc/build/changelog/changelog_14.rst

Reviewer guidance

Do Python tests still pass?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from jredrejo August 11, 2023 18:34
@rtibbles rtibbles added TODO: needs review Waiting for review TAG: dependencies Pull requests that update a dependency file labels Aug 11, 2023
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking changelog https://docs.sqlalchemy.org/en/20/changelog/changelog_14.html#change-1.4.49 nothing appears to affect our codebase directly , and in any case, as you mentioned, there are several regressions and bug fixes.
Tested it. So far, so good.

@jredrejo jredrejo merged commit 5a4c7c4 into release-v0.16.x Aug 14, 2023
@rtibbles rtibbles deleted the rtibbles-patch-1 branch August 16, 2023 19:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
SIZE: very small TAG: dependencies Pull requests that update a dependency file TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants