Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Plugin machinery tweaks #11098

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Plugin machinery tweaks #11098

merged 1 commit into from
Aug 16, 2023

Conversation

rtibbles
Copy link
Member

Summary

  • Adds debug log for hook registration.
  • Do not blanket catch import errors to prevent swallowing meaningful errors.

@rtibbles rtibbles requested a review from bjester August 14, 2023 21:53
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Aug 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.0b1.dev0_git.62.gf426c448.pex
Windows Installer (EXE) kolibri-0.16.0b1.dev0+git.62.gf426c448-unsigned.exe
Debian Package kolibri_0.16.0b1.dev0+git.62.gf426c448-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.0b1.dev0+git.62.gf426c448-0.3.0.dmg
TAR file kolibri-0.16.0b1.dev0+git.62.gf426c448.tar.gz
WHL file kolibri-0.16.0b1.dev0+git.62.gf426c448-py2.py3-none-any.whl

@rtibbles
Debug log for hook registration.
5a67658 
Do not blanket catch import errors to prevent swallowing meaningful errors.
bjester
bjester approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code makes sense

@bjester bjester merged commit 1428c19 into learningequality:release-v0.16.x Aug 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bjester bjester bjester approved these changes

Assignees
No one assigned
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small SIZE: very small
Projects
None yet
Milestone
Kolibri 0.16.0: Bugs and Regressions
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @bjester