-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
kolibri studio no of remote channel issue resolved #11100
kolibri studio no of remote channel issue resolved #11100
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to make sure that we are using the translated string!
kolibri/plugins/learn/assets/src/views/LibraryPage/PinnedNetworkResources.vue
Outdated
Show resolved
Hide resolved
Thank you, @GarvitSinghal47. We noticed one more thing here that I will need to look into in more detail than I can manage now so I will return to it on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again, @GarvitSinghal47, this is a good start, thank you! Due to the similarity of some places in Kolibri Library, during the first review we didn't notice a few things, apologies. There will be a few updates needed.
(1) The issue reported in #10931 is related to the missing number of available channels on the "All libraries" page rather than on the root "Library" page. I double-checked designs and we don't want to show the number on the root "Library" page like implemented in this PR. You can follow the guidance in the issue to navigate to the right place, however you'd need to have some other devices on your network to have "View all" button available like here
Alternatively, I think that navigating to http://localhost:8000/en/learn/#/explore_libraries?prevName=LIBRARY should do, too.
(2) We only want to display the number of channels for Kolibri Library (Studio) library rather than the total number of channels on remote devices.
Let me know if you needed some help with setting up another device on your network. It's not that complicated and we can support. It might be useful for you to be able to navigate everywhere and also to check that the correct number is calculated.
Oh i realized now after seeing the design docs i have done it in the wrong place, will move it to all library page . @MisRob i need help in setting it up in my network as while i am trying to access this on my wifi with the url given in device then info , i was able to get the url but the problem i am facing in both my other laptop and the mobile is that the loading page is just appearing and not forwarding to auth page . and when i inspect the page it is showing err connection refused and uncaught reference error : kolibricore app global is not defined. i have tried removing all security related thing of browser and the security software of my laptop as well. can you tell me what is the issue and how to resolve it . |
@GarvitSinghal47 just to clarify, you're doing this so you can see more devices in the Library, is that correct? |
I will need to move to something else in a moment, so if that's case, I'd recommend a simpler way of running another device alongside your dev server, just one laptop needed :) You can download pex file from one of the latest Build Assets(if you can access the page), for example this one https://github.com/learningequality/kolibri/suites/15341352681/artifacts/876105184. Then unzip the file and run When it comes to |
Yes , to see more devices . |
updated video after changes in description |
:pinIcon="getPinIcon(true)" | ||
:disablePinDevice="device['instance_id'] === studioId" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is perfectly aligned with the designs, but let me check with the team at first before we merge it because disabling pinning the Kolibri Library here is looking pretty intentional so now I am not clear if the deviation from the designs had a reason or if it's just our oversight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert this change - the designs are out of date, and this should indeed be disabled instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @GarvitSinghal47
#10931
Summary
Added the no of remote channel line under the library .
Before :
channelnobefore.webm
After :
channelnoafter.webm
…
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)