Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do better availability checks for individual resource import #11181

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Aug 30, 2023

Summary

  • Adds validation for checksums to public file checksum endpoint
  • Updates individual content resource manager to check for file availability on remote before import
  • Exempts Studio from these checks

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from bjester August 30, 2023 20:37
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Aug 30, 2023
@rtibbles rtibbles force-pushed the peerless_content_syncing branch from 7baa76f to 690aa0e Compare August 30, 2023 21:34
@rtibbles rtibbles marked this pull request as ready for review August 30, 2023 21:34
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM-- will rebase my PR and test

@rtibbles rtibbles merged commit c08e1af into learningequality:release-v0.16.x Aug 31, 2023
@rtibbles rtibbles deleted the peerless_content_syncing branch August 31, 2023 03:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants