Set default value for storage limit slider

[nikkuAg]

Summary

I've implemented a functionality that sets the limitForAutodownload to 80% of the available freeSpace if the checkbox is not selected; otherwise, it retrieves the value from the API.

device-settings-google-chrome-2023-09-05-00-00-56_OOUXovPp.mp4

…

References

#11176
…

Reviewer guidance

…

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b5.dev0_git.196.g65018809.pex
Windows Installer (EXE)	kolibri-0.16.0b5.dev0+git.196.g65018809-unsigned.exe
Debian Package	kolibri_0.16.0b5.dev0+git.196.g65018809-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b5.dev0+git.196.g65018809-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b5.dev0+git.196.g65018809-0.1.0-debug.apk
TAR file	kolibri-0.16.0b5.dev0+git.196.g65018809.tar.gz
WHL file	kolibri-0.16.0b5.dev0+git.196.g65018809-py2.py3-none-any.whl

[pcenov]

Hi @nikkuAg and @MisRob, this is working mostly correctly now, however in my Ubuntu VM I am seeing the value in GB as 60.800000000000004 which is then displayed as 60GB if I save the changes and refresh the page. I think this value should be always rounded and in this case it should be rounded to 60.8 GB

2023-09-05_16-42-54.mp4

[nikkuAg]

I will look into it

[nikkuAg]

@pcenov I have solved the bug

[pcenov]

Thank you @nikkuAg I confirm that this is fixed now!

[rtibbles]

I can imagine a situation where the freeSpace value is actually 0 - i.e. when there is no free space on the device. Perhaps it would be better if this were initialized as null rather than 0 to be able to do a check on whether it has been set or not (would have to make sure anywhere it was being used was being guarded against the non-numeric value).

[nikkuAg]

I have updated the changes

[nikkuAg]

@rtibbles @pcenov
The yarn run devserver command is giving an error suddenly: uncaught reference error: kolibricoreappglobal is not defined.

[MisRob]

@nikkuAg can you try to run make clean before running the dev server?

[nikkuAg]

@MisRob
After running the command make clean and then yarn run devserver I am getting the following error

[MisRob]

@nikkuAg Is your virtual environment activate? Could you reinstall Python packages? If that doesn't help, I would ask you for all logs that you can send us.

[MisRob]

@nikkuAg Ah now I've remembered that after make clean you will need to run pip install -e . (don't forget the dot). So try this at first please.

[nikkuAg]

@MisRob Thank you for the help, it is working now.