Fix global loading state on root Coach pages #11218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes both global and local loaders being displayed when loading the classes page.
on root coach pages. Even though global/local loading state is set in some loading pages handlers, before running individual pages handlers, coach plugin fetches some data in global 'beforeRoute'. That takes significantly more time than individual handlers. Not having loading state set in this 'beforeRoute' caused seemingly missing global loader (even though it was displayed very briefly for individual handlers)
github-actions
bot
added
APP: Coach
MisRob
requested review from
akolson,
nucleogenesis,
marcellamaki and
rtibbles
Build Artifacts
|
rtibbles
approved these changes
Sep 11, 2023
| @@ -26,7 +26,8 @@ export default [ | |||
| path: '/classes', | |||
| component: CoachClassListPage, | |||
| handler(toRoute) { | |||
| store.dispatch('loading'); | |||
| // loading state is handled locally | |||
| store.dispatch('notLoading'); | |||
There was a problem hiding this comment.
This accords with my general sense that we can reduce the role of the core loading state to be about toggling the linear loader when the navigation is still resolving. In this frame, we could handle it entirely within our core routing setup, where we toggle it on before route enter, and toggle it after after the route has resolved.
9 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See commit messages for more details.
Comments
Further improvements in the Coach loading states and navigation overall are needed. See #11219.
References
Closes #10729
Reviewer guidance
On slow network, navigate the root Coach pages and tabs
Testing checklist
PR process
Reviewer checklist
yarnandpip)