Navigation tweaks

[rtibbles]

Summary

• Prevents redundant navigation errors by using next rather than router.replace for synchronous navigation guards
• Ensures that the side nav always closes for navigation events, now that it always displays as a modal
• Ensures backlink gets properly generated for Home Page by passing classId parameter

References

Fixes #11253

Reviewer guidance

Are all the behaviours working as one might expect?
Did I miss any instances where Home, Reports, or Plan links are being generated without a classId (now that the parameter is optional, it does not automatically get supplied by the getRoute method.

New side nav behaviour - only does the toggle behaviour when navigating within an SPA, otherwise it looked a bit janky:
Screencast from 09-15-2023 04:03:30 PM.webm

Bug fix for back route:
Screencast from 09-15-2023 04:00:21 PM.webm

No redundant navigation errors:
Screencast from 09-15-2023 04:01:35 PM.webm

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b5.dev0_git.145.g27153dfe.pex
Windows Installer (EXE)	kolibri-0.16.0b5.dev0+git.145.g27153dfe-unsigned.exe
Debian Package	kolibri_0.16.0b5.dev0+git.145.g27153dfe-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b5.dev0+git.145.g27153dfe-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b5.dev0+git.145.g27153dfe-0.1.0-debug.apk
TAR file	kolibri-0.16.0b5.dev0+git.145.g27153dfe.tar.gz
WHL file	kolibri-0.16.0b5.dev0+git.145.g27153dfe-py2.py3-none-any.whl

[thanksameeelian]

i've read through the code and have been clicking around and almost everything is looking good to me. and kudos to @pcenov for finding that redundant navigation problem!

the only small issue i noticed was while i was testing out that scenario of clicking on the same sidenav link twice. afterwards, the page gave the appearance of perpetual loading, with the top loading bar running continuously

perpetual-loading.mov

[rtibbles]

Seems like this was happening because we always set the global loading state to true before entering any route in coach. Have resolved it for now by turning it off when the class param required guard returns true.

Ultimately, my suggestion elsewhere has been that we should only use the core loading state to show navigation is still in progress and control it entirely from navigation guards in the core of the app - but that's for another day!

[pcenov]

Thanks @rtibbles and @thanksameeelian - no extra issues uncovered while regression testing, good to go!

[thanksameeelian]

looks great to me!