Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only do an update broadcast if relevant info has changed #11258

Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Sep 16, 2023

Summary

  • Adds a last_seen value to KolibriInstance and set to time.time() when initialized
  • Adds an __eq__ to KolibriInstance
  • If the previously registered instance is equal to the current one, and the last_seen is not different by more than SERVICE_TTL, then do not broadcast an update
  • Adds tests

References

Fixes #11221

Reviewer guidance

Do rapid zeroconf updates get skipped now?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Sep 16, 2023
@rtibbles rtibbles requested a review from bjester September 16, 2023 00:11
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Sep 16, 2023
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit ab1d2b9 into learningequality:release-v0.16.x Sep 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: medium TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only trigger Zeroconf update if the instance data or URL differs
2 participants