Replaced KResponsiveWindow mixin by useKResponsiveWindow composable - … #11365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Media Player plugin
Build Artifacts
|
rtibbles
requested changes
Oct 8, 2023
| mixins: [commonCoreStrings, responsiveWindowMixin, responsiveElementMixin], | ||
| mixins: [commonCoreStrings, responsiveElementMixin], | ||
| setup() { | ||
| const { windowIsSmall } = useKResponsiveWindow(); |
There was a problem hiding this comment.
The windowIsPortrait property is also used, so must be destructured here and returned from the setup method.
There was a problem hiding this comment.
I have made the necessary changes; please check it once.
rtibbles
approved these changes
Oct 9, 2023
nucleogenesis
pushed a commit
to nucleogenesis/kolibri
that referenced
this pull request
Oct 11, 2023
… Media Player plugin (learningequality#11365) Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Media Player plugin
AllanOXDi
pushed a commit
to AllanOXDi/kolibri
that referenced
this pull request
Nov 3, 2023
… Media Player plugin (learningequality#11365) Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Media Player plugin
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Media Player plugin
Testing checklist
PR process
Reviewer checklist
yarnandpip)