-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Clean up renderer height styling behaviour #11383
Clean up renderer height styling behaviour #11383
Conversation
Remove need for global HTML scroll limitations.
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through the code things look good. I'll spin it tomorrow so I can better visualize the styles in devtools and test things out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both pdf and HTML resources are displayed correctly except in mobile view where the PDFs are initially displayed in all black that is until the user selects the bookmarks menu. Seems that this is happening when viewing in resolution less than 840 px.
2023-10-11_15-19-14.mp4
Interesting, thanks for the check, @pcenov! I'll see what's happening there. |
Rescale on first load if sidebar is shown.
OK, I think this should all be working as expected now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm - everything is working as expected now.
Summary
References
Fixes #11311
Reviewer guidance
Create a lesson

Manage resources
Try to add a PDF and preview it
Observe that the page can still scroll
View a PDF in Learn, ensure that it behaves as expected

View an HTML5 app in Learn ensure that it behaves as expected
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)