Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

priority of tasks can be declared via the API #11445

Merged
merged 4 commits into from
Oct 24, 2023
Merged

priority of tasks can be declared via the API #11445

merged 4 commits into from
Oct 24, 2023

Conversation

im-NL
Copy link
Contributor

@im-NL im-NL commented Oct 21, 2023 •
edited
Loading

Summary

Reviewer guidance

  • all tests are passing and priority option has been added to the enqueue_args serializer.
  • I could not completely test the PR manually and would need either someone else to test or get guidance on how to test this change

Testing checklist

  • Contributor has fully tested the PR manually

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Oct 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.0b6.dev0_git.264.gd04a83fa.pex
Windows Installer (EXE) kolibri-0.16.0b6.dev0+git.264.gd04a83fa-unsigned.exe
Debian Package kolibri_0.16.0b6.dev0+git.264.gd04a83fa-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.0b6.dev0+git.264.gd04a83fa-0.3.0.dmg
Android Package (APK) kolibri-0.16.0b6.dev0+git.264.gd04a83fa-0.1.0-debug.apk
TAR file kolibri-0.16.0b6.dev0+git.264.gd04a83fa.tar.gz
WHL file kolibri-0.16.0b6.dev0+git.264.gd04a83fa-py2.py3-none-any.whl

rtibbles
rtibbles reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right change - one possible tweak to tighten up the implementation.

Would also be good to add additional tests to the EnqueueArgsCreateTestCase here: https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/core/tasks/test/test_api.py#L598 to validate this update.

@im-NL im-NL requested a review from rtibbles October 23, 2023 11:23
rtibbles
rtibbles approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! This is safe to merge to release-v0.16.x so I will do a little rebasing here to retarget it.

@rtibbles rtibbles changed the base branch from develop to release-v0.16.x October 23, 2023 22:31
@rtibbles rtibbles merged commit 78993d2 into learningequality:release-v0.16.x Oct 24, 2023
AllanOXDi pushed a commit to AllanOXDi/kolibri that referenced this pull request Nov 3, 2023
@im-NL @AllanOXDi
priority of tasks can be declared via the API (learningequality#11445)
43854d4 
* priority of tasks can be declared via the API

* linting and bug fixes

* use .format() instead of f strings

* added test cases and use choicefield instead of integerfield
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees
No one assigned
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set task priority via the API
2 participants
@im-NL @rtibbles