Moves setting current_channel to init

[marcellamaki]

Summary

The error
AttributeError: 'NoLearningActivitiesChannelImport' object has no attribute 'current_channel' was causing channel upgrade to break. The lookup was moved to init() so that it would be defined before it was called in each place it was used

References

Fixes #11557

channel-import-fixes.mp4

Reviewer guidance

Does updating/upgrading a channel to a new version work?
Are there any possible side effects of when this might still not be defined, at this point in the code? (i.e. should some error handling be added)

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[bjester]

Couple changes needed to ensure defensiveness against more errors, but glad this fixed the issue!

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b9.dev0_git.18.gbd1e63b6.pex
Windows Installer (EXE)	kolibri-0.16.0b9.dev0+git.18.gbd1e63b6-unsigned.exe
Debian Package	kolibri_0.16.0b9.dev0+git.18.gbd1e63b6-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b9.dev0+git.18.gbd1e63b6-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b9.dev0+git.18.gbd1e63b6-0.1.0-debug.apk
TAR file	kolibri-0.16.0b9.dev0+git.18.gbd1e63b6.tar.gz
WHL file	kolibri-0.16.0b9.dev0+git.18.gbd1e63b6-py2.py3-none-any.whl

[bjester]

LGTM

[pcenov]

I confirm - the channel update is working correctly now!

[marcellamaki]

can somebody (@bjester @rtibbles ) confirm my python test "fixes" are reasonable before merge? if we are being honest I solved this via the error messages not via a deep understanding of why my changes affected these tests in this way

[bjester]

can somebody (@bjester @rtibbles ) confirm my python test "fixes" are reasonable before merge? if we are being honest I solved this via the error messages not via a deep understanding of why my changes affected these tests in this way

They look appropriate to me!