Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce whl size, bundle C extensions for all Python 3 versions on Windows #11636

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Removes the duplication of dependencies for abi3 compatible bundles (i.e. cryptography)
  • Instead, if we are on an abi3 compatible Python version (see https://docs.python.org/3/c-api/stable.html#limited-c-api), and we have bundled platform and machine architecture dependencies for it, we add the relevant folder to the sys.path

References

Resolves build failure caused by an overly large wheel file

Reviewer guidance

Verify that the built WHL file is less than our 100MB limit.
Install the WHL file into a clean Python 3.6+ virtual environment
Run kolibri shell
Verify that import cryptography does not produce an ImportError


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Dec 14, 2023
@rtibbles rtibbles requested review from bjester and jredrejo December 14, 2023 23:19
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Dec 14, 2023
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and tested as the description says without any issue.

@rtibbles rtibbles merged commit 62db7dc into learningequality:release-v0.16.x Dec 15, 2023
33 checks passed
@rtibbles rtibbles deleted the big_whl_keep_on_turning branch December 15, 2023 18:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants