-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Enque_lifo_job #11687
Merged
rtibbles
merged 13 commits into
learningequality:release-v0.16.x
from
nick2432:enque_lifo_job
Jan 9, 2024
Merged
Enque_lifo_job #11687
rtibbles
merged 13 commits into
learningequality:release-v0.16.x
from
nick2432:enque_lifo_job
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, but there is one more thing needed to ensure the LIFO behaviour!
Build Artifacts
|
@rtibbles I have changed what you said. |
rtibbles
approved these changes
Jan 9, 2024
Thanks @nick2432 - this is great, thanks for your contribution! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the option for Last-In-First-Out (LIFO) job queueing
Changes Made
enqueue_lifo_job
, for explicitly enqueuing LIFO jobs.…
Testing
…
Related Issues
Closes #11506
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)