Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enque_lifo_job #11687

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Conversation

nick2432
Copy link
Contributor

@nick2432 nick2432 commented Jan 3, 2024

Summary

This pull request introduces the option for Last-In-First-Out (LIFO) job queueing

Changes Made

  • Added a new method, enqueue_lifo_job, for explicitly enqueuing LIFO jobs.
  • Updated relevant tests to cover the new LIFO functionality.

Testing

  • Added unit tests for the new LIFO functionality.
  • Conducted manual testing .

Related Issues

Closes #11506


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Jan 3, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, but there is one more thing needed to ensure the LIFO behaviour!

@nick2432 nick2432 requested a review from rtibbles January 4, 2024 12:57
@nick2432
Copy link
Contributor Author

nick2432 commented Jan 4, 2024

Screenshot from 2024-01-04 18-05-09

@nick2432
Copy link
Contributor Author

nick2432 commented Jan 9, 2024

@rtibbles I have changed what you said.

@rtibbles rtibbles merged commit 92bad83 into learningequality:release-v0.16.x Jan 9, 2024
33 checks passed
@rtibbles
Copy link
Member

rtibbles commented Jan 9, 2024

Thanks @nick2432 - this is great, thanks for your contribution!

@nick2432 nick2432 deleted the enque_lifo_job branch January 23, 2024 06:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to change current tasks queue by a tasks stack
2 participants