Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Contributors welcome to our authors.md! #11688

Merged

Conversation

vkWeb
Copy link
Member

@vkWeb vkWeb commented Jan 3, 2024

Summary

This PR attempts at fixing the Github action that adds new contributor to AUTHORS.md.

References

Closes #11563.

Reviewer guidance

The action should add vkWeb to the AUTHORS.md file and commit to this pull request branch.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: small labels Jan 3, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work - I am still confused why the pre-commit-lite action is failing to work.

@vkWeb
Copy link
Member Author

vkWeb commented Jan 4, 2024

Yes, pre-commit-lite action looks solid. Did we install their app as its a required step for the action to work?
https://pre-commit.ci/lite#setup

@vkWeb
Copy link
Member Author

vkWeb commented Jan 4, 2024

I will merge this and we will test, we can switch to pre-commit-lite if the requirement knocks the door.

@vkWeb vkWeb merged commit b71e893 into learningequality:release-v0.16.x Jan 4, 2024
33 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix/finish "Add Contributor to AUTHORS.md" action
2 participants