-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Delete previously committed message files with outdated naming scheme update all translations #11705
Delete previously committed message files with outdated naming scheme update all translations #11705
Conversation
8557355
to
0842cde
Compare
Build Artifacts
|
Checked out the branch in development and switched to several different languages in the UI: no errors observed on the front end and nothing in the console. I'll smoke test with the built asset before approving. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates LGTM - will leave final approval to Radina's smoke test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good to go! 💯
Summary
References
Seems to have been extant since this PR was merged: #5887
Finalizes translation message files for release
Reviewer guidance
Should give no ill effects - smoke test by looking at the user interface, and ensuring that the console doesn't warn about missing strings from message files.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)