Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delete previously committed message files with outdated naming scheme update all translations #11705

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 6, 2024

Summary

  • It seems that we had failed to cleanup previously committed English message files when we changed the naming scheme for message files, and they have been bloating the Kolibri distribution ever since.
  • Updates the frontend JSON message file creation code to clear out existing JSON files before generating
  • Regenerates all JSON files
    • Deletes old, unused message files
    • Adds in messages in message files where components have been additionally imported and are now required

References

Seems to have been extant since this PR was merged: #5887

Finalizes translation message files for release

Reviewer guidance

Should give no ill effects - smoke test by looking at the user interface, and ensuring that the console doesn't warn about missing strings from message files.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jan 6, 2024
@rtibbles rtibbles marked this pull request as draft January 6, 2024 01:55
@github-actions github-actions bot added DEV: tools Internal tooling for development SIZE: medium labels Jan 6, 2024
@rtibbles rtibbles marked this pull request as ready for review January 6, 2024 02:17
@rtibbles rtibbles changed the title Delete previously committed message files with outdated naming scheme Delete previously committed message files with outdated naming scheme update all translations Jan 6, 2024
@radinamatic
Copy link
Member

Checked out the branch in development and switched to several different languages in the UI: no errors observed on the front end and nothing in the console.

I'll smoke test with the built asset before approving.

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code updates LGTM - will leave final approval to Radina's smoke test

@radinamatic
Copy link
Member

Still not seeing anything concerning in the UI on Ubuntu 20.04, and guessing these console errors have nothing to do with the changes in this PR.

Firefox Chrome
2024-01-08_18-53-30 2024-01-08_18-58-52

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to go! 💯 :shipit:

@rtibbles rtibbles merged commit edc50e6 into learningequality:release-v0.16.x Jan 8, 2024
33 checks passed
@rtibbles rtibbles deleted the erroneous_files branch January 8, 2024 20:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: tools Internal tooling for development SIZE: medium SIZE: very large TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants