Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Properly handle list shaped details. #11775

Merged

Conversation

rtibbles
Copy link
Member

Summary

Fixes the broken fix #11770 which didn't properly account for error details being a list

References

Actually fixes #11768

Reviewer guidance

Merge an on my own setup user into a facility that requires passwords


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jan 23, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... APP: User Re: User app (sign-in, sign-up, user profile, etc.) SIZE: small labels Jan 23, 2024
@radinamatic
Copy link
Member

Joining facility was successful! 🎉

2024_01_23_22 10 45

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 👏🏽 💯 :shipit:

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm, and @radinamatic's manual QA has confirmed. (Richard and I also tested this via zerotier)

@marcellamaki marcellamaki merged commit 6b8acac into learningequality:release-v0.16.x Jan 23, 2024
34 checks passed
@rtibbles rtibbles deleted the exceptional_auth branch January 23, 2024 23:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
APP: User Re: User app (sign-in, sign-up, user profile, etc.) DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging user account into account with same name gives 401 when authenticating
3 participants