-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade to KDS v3.0.0 and reference npm package #11873
Conversation
- Upgrades KDS from somewhere in the middle of v3.0.0 commits to v3.0.0. Includes Kolibri code updates related to the breaking change in regards to value --> buttonValue renaming. See KDS v3.0.0 release notes https://github.com/learningequality/kolibri-design-system/releases/tag/v3.0.0 - Uses npm package to install KDS
Build Artifacts
|
Hi @pcenov, would you have a moment to confirm that radio buttons at a few (any) places in Kolibri still work well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MisRob - no issues observed with the radio buttons in the setup wizard and anywhere else!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find any places that still needed changes, everything looks good and works as expected!
Thanks both |
Summary
Upgrades KDS from somewhere in the middle of v3.0.0 commits to v3.0.0. Includes Kolibri code updates related to the breaking change in regards to
value
-->buttonValue
renaming. See KDS v3.0.0 release notes. I've manually tested a few places with radio buttons after the update but not all of them.Uses npm package to install KDS
~
. This has a benefit of knowing exactly what version is installed.Reviewer guidance
value
-->buttonValue
value
was indeed to use it as a prop to set the radio button's value HTML attribute (rather than as Vue value binding - in such cases it should stay:value
)Testing checklist
fullypartially :) tested the PR manuallyIf there are any front-end changes, before/after screenshots are includedCritical user journeys are covered by Gherkin storiesCritical and brittle code paths are covered by unit testsPR process
If this is an important user-facing change, PR or related issue has a 'changelog' labelIf this includes an internal dependency change, a link to the diff is providedReviewer checklist
yarn
andpip
)