Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add IsAuthenticated permission class in api/content/contentrequest #11995

Merged

Conversation

thesujai
Copy link
Contributor

Summary

Add IsAuthenticated permission class in /api/content/contentrequest/ to prevent anonymous access

References

Discussed in #11978 (comment)

Reviewer guidance

I tried the curl command without authorization, it passed, but failed without it.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@thesujai thesujai changed the title add IsAuthenticated permission class in api/content/contentrequest Add IsAuthenticated permission class in api/content/contentrequest Mar 15, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Mar 15, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rtibbles rtibbles merged commit 8ca3654 into learningequality:release-v0.16.x Mar 17, 2024
34 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants