Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update README.md #12009

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

poju3185
Copy link
Contributor

Summary

Update documentation. The variable name in downloadH5PVendor.js should be h5pCommit instead of h5pVersion.

References

https://github.com/learningequality/kolibri/blob/release-v0.16.x/packages/hashi/downloadH5PVendor.js


PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob requested a review from AllanOXDi March 22, 2024 04:51
@MisRob MisRob added the TODO: needs review Waiting for review label Mar 22, 2024
@MisRob MisRob requested a review from ozer550 March 22, 2024 04:52
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I must have changed it at some point without updating the readme, thank you!

@rtibbles rtibbles self-assigned this Mar 22, 2024
@rtibbles rtibbles merged commit 523e62a into learningequality:release-v0.16.x Mar 22, 2024
34 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants