Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove CoreSnackbar from core API. #12627

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Removes CoreSnackbar from the core API.
  • Moves it into the GlobalSnackbar component where it is used.
  • Keeps them separate for now, as the creation and teardown of the inner component is important for the life cycle of the snackbar.

References

Fixes #12625

Reviewer guidance

Do snackbars still work as intended?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM - smoke tested locally and was able to find my way to the schnaaaaaackbars

@rtibbles rtibbles merged commit 7878b94 into learningequality:develop Sep 16, 2024
34 checks passed
@rtibbles rtibbles deleted the schnaaaaaaaaack branch September 16, 2024 15:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CoreSnackbar from core API - move into GlobalSnackbar, the only place it is used
2 participants