Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix filters in csv exports for Lessons page #12949

Merged

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Dec 16, 2024

Summary

  • Refactor sorting and filtering in COACH->LESSONS page.
  • Reflect the filters while downloading the csv files.

Reviewer guidance

  • Add some lessons.
  • Try filtering combinations with status and recipients.
  • Download CSV and see if the filters reflect.

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Dec 16, 2024
@pcenov
Copy link
Member

pcenov commented Dec 18, 2024

Thanks @ozer550 - I confirm that now I am correctly seeing the filtered values when I export the report as CSV.

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ozer550!

@marcellamaki marcellamaki merged commit 2ae2257 into learningequality:develop Dec 19, 2024
37 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants