Feature/topicmove #119
Merged
Feature/topicmove #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/codecleanup
…another forum. Coding style errors are fixed
|
|
templates/discussion_list.mustache
Outdated
| @@ -202,10 +202,19 @@ | |||
| {{^ lastpostusername }}-{{/ lastpostusername }}<br /> | |||
| <a href="{{ lastpostlink }}">{{ lastpostdate }}</a> | |||
| </td> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Please insert an additional check - {subscribeormove} which only renders the column if the user can subscribe or move the topic or both.
classes/task/send_daily_mail.php
Outdated
| $userto = $DB->get_record('user', array('id' => $user->userid)); | ||
| $from = \core_user::get_noreply_user(); | ||
| $subject = get_string('tasksenddailymail', 'mod_moodleoverflow'); | ||
| mtrace($message); |
There was a problem hiding this comment.
remove mtrace as for many post this might make the log very big
lib.php
Outdated
| // Terminate if the process takes more time then two minutes. | ||
| core_php_time_limit::raise(120); | ||
|
|
||
| // Tracing information. | ||
| mtrace('Processing user ' . $userto->id); | ||
|
|
||
| mtrace('Mail setting of user: ' . $userto->maildigest); |
There was a problem hiding this comment.
remove mtrace as for many post this might make the log very big
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature is almost completed, only testing is missing:
A Teacher can move a topic by clicking the arrow icon on a discussion:
With clicking the icon, a table with all available courses will show up on the top of the forum.
By clicking on an arrow by the forum, the topic will be moved to the forum an the discussion site will reload without the table:
