fix upload workflow #185
Merged
fix upload workflow #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/behat/manual_trigger.feature
Outdated
| @@ -1,4 +1,4 @@ | |||
| @tool @tool_lifecycle | |||
| @tool @tool_lifecycle @manuel_trigger | |||
There was a problem hiding this comment.
Small typo in @manual_trigger
tests/fixtures/simpleworkflow.xml
Outdated
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0"?> | |||
| <workflow id="143" title="Ein Workflow basierend auf Rollen" timeactive="1688629134" timedeactive="" sortindex="6" manual="" displaytitle="Find courses without students" rollbackdelay="7776000" finishdelay="7776000" delayforallworkflows="0"> | |||
| <step id="100" instancename="Test all courses" workflowid="143" subpluginname="adminapprove" sortindex="1"> | |||
There was a problem hiding this comment.
Adminapprove is not in this repo. Thats probably the reason behat fails
| @@ -102,6 +101,7 @@ private function load_workflow() { | |||
| $this->workflow->timeactive = null; | |||
| $this->workflow->timedeactive = null; | |||
| $this->workflow->sortindex = null; | |||
| $this->workflow->id = workflow_manager::insert_or_update($this->workflow); | |||
There was a problem hiding this comment.
This line, and returning the workflow id in insert_or_update is theoretically not necessary, because $this->workflow is passed by reference to it, right?
NinaHerrmann
added a commit
that referenced
this pull request
Jun 19, 2024
* Removed , * CI: Update for Moodle 4.2 * Workflow backup: Do not save attributes when they are null * Bump version * MBS-7377: Fix workflowoverview for big instances * Fix wrong calculation of courses counts in template context * fix upload workflow (#185) * fix upload workflow * inserting feedback * finally * Add check if process exists. (#191) This prevents courses to be processed which had been rescued by the teacher. * Update README.md Make Subplugin List (and link to wiki) more apparent * Improve help text for integration of icons (manual trigger) (#193) * Improved help text for the integration of icons * Improved help text for the integration of icons * Update for Moodle 4.3 (#190) * CI: Update for Moodle 4.3 * Prevent dynamic property access on classes for PHP 8.2 * phpcbf for styles etc. --------- Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de> Co-authored-by: NinaHerrmann <nina.herrmann@uni-muenster.de> * Hide menu when there is no manual workflow (#195) Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de> * Fix step and trigger reordering: only change the relevant workflow (#200) * Reorder the remaining active workflows when disabling a workflow (#201) This fixes #128. * Show menu entry when a manual or automatic workflow is active (#199) * Show menu point when a manual or automatic workflow is active * Rename reset cache function * Show menu entry if there are workflows other than the default two --------- Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de> * Check backup consistency before importing workflow (#196) * Check backup consistency before importing workflow * Fix PHPDocs * Use existing category in backup_and_restore test * lifecycletrigger_categories: A bit of general refactoring * lifecycletrigger_categories: Don't fail if category doesn't exist * Add possibility to force import of errorneous backup * Use $force = false as default in restore_workflow:execute * Display only unique errors when Workflows causes multiple errors --------- Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de> Co-authored-by: NinaHerrmann <nina.herrmann@uni-muenster.de> * CI: Update for Moodle 4.4 * Codestyle PHPCBF * Sort strings in lang files alphabetically * Fix sortindex gaps in upgrade step * Bump version * The columns in active_manual_workflows_table shouldn't be sortable * Shell escape the release notes in the release workflow (#207) Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de> * Fix mustache * added mtrace statement for logging failed mails (#214) * Shell escape release workflow for realsies this time (#208) --------- Co-authored-by: Justus Dieckmann <justusdieckmann@wwu.de> Co-authored-by: Philipp Memmel <philipp.memmel@gmail.com> Co-authored-by: Justus Dieckmann <45795270+justusdieckmann@users.noreply.github.com> Co-authored-by: Melanie Treitinger <66598405+melanietreitinger@users.noreply.github.com> Co-authored-by: KerstinSc <kerstin.schmidt@th-nuernberg.de> Co-authored-by: Kata <35190838+olivabigyo@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #183