Skip to content

makeprg incorrectly set to (hledger -f g:ledger_main::S print > /dev/null) #121

Closed
@gregorias

Description

@gregorias

Since #119 vim-ledger incorrectly sets makeprg to (hledger -f g:ledger_main::S print > /dev/null) in Neovim.

The root cause is that the expansion works differently between Vim and Neovim. Also, ::S suffix only works if g:ledger_main is a special wildcard. Was that the intention?

For addressing this issue, we could do one of the following:

  1. Roll back Properly escape paths so spaces don't error on load #119, because it's a breaking change.
  2. Change to expand(g:ledger_main . '::S') if g:ledger_main being a wildcard is intended. This works in both Vims.
  3. Check for Neovim and do 2. for Neovim only.
  4. Let users configure the expanded filename by themselves.
  5. Ignore, because you don't care about supporting Neovim.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions