Skip to content

fix: no trailing "?" for empty query table #289

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: no trailing "?" for empty query table #289

merged 3 commits into from
Mar 14, 2023

Conversation

StarlightIbuki
Copy link
Contributor

When request or request_uri are called with param.query set to an empty table, the result URI would contain a trailing "?".

@pintsized
Copy link
Member

Thanks for this 👍 Looks good, except the luacheck failure on white space. Please fix this up and I'll get it merged.

StarlightIbuki
StarlightIbuki commented Mar 14, 2023
View reviewed changes
StarlightIbuki
StarlightIbuki commented Mar 14, 2023
View reviewed changes
@pintsized pintsized merged commit 3ad9ff6 into ledgetech:master Mar 14, 2023
@StarlightIbuki
Copy link
Contributor Author

@pintsized Hi. Are we going to have a release soon? We have a workaround fix(some client does not work with trailing ?) relying on this.
If there won't be a release soon, we are considering another workaround for that workaround fix🤦‍.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StarlightIbuki @pintsized