Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

STEP2_PR후개선 #9

Closed
leeari95 opened this issue Jan 12, 2022 · 0 comments
Closed

STEP2_PR후개선 #9

leeari95 opened this issue Jan 12, 2022 · 0 comments
Assignees
@llghdud921 @leeari95

Comments

@leeari95
Copy link
Owner

No description provided.

leeari95 added a commit that referenced this issue Jan 12, 2022
@leeari95
refactor: Asset에 등록되어있는 이미지 이름, Scales, Resizing 설정 수정 #9
ab7156f 
- 단순 샘플용 이미지기 때문에 Scales를 individual에서 single로 수정
- 파일이름을 식별 가능한 이름으로 수정
llghdud921 added a commit that referenced this issue Jan 12, 2022
@llghdud921
refactor: 전반적인 네이밍 수정 #9
ffd54e1 
- configureProduct, configureStyle로 네이밍 변경 및 매개변수 label of 설정
- gridIdentifier으로 네이밍 변경
- formattedString으로 네이밍 변경
- encodedData로 네이밍 변경
- width로 네이밍 변경
leeari95 added a commit that referenced this issue Jan 12, 2022
@leeari95
refactor: 뷰 구성 시 cell을 바인딩 하지 못할 경우 에러 발생 얼럿을 띄우도록 수정 #9
b1aeb83
llghdud921 added a commit that referenced this issue Jan 12, 2022
@llghdud921
refactor: identifier로 뷰 전환하는 조건문삼항연산자로 개선 #9
3b91e40
leeari95 added a commit that referenced this issue Jan 12, 2022
@leeari95
refactor: NetworkManager 프로퍼티가 private 하도록 접근제어 추가 #9
c08cc5b
leeari95 added a commit that referenced this issue Jan 12, 2022
@leeari95
refactor: 동적으로 레이아웃을 잡도록 UICollectionViewDelegateFlowLayout을 채택 #9
ceaf667 
- ProductsCollectionView 내부에 레이아웃 관련 프로퍼티 추가
llghdud921 added a commit that referenced this issue Jan 12, 2022
@llghdud921
refactor: 동적 레이아웃을 위한 collectionview 프로퍼티 생성 #9
782bc75 
- 기존의 listFlowLayout, gridFlowLayout 삭제
- cellstyle에 따른 itemsize 조절하는 cellSize() 구현
- list, grid마다 갖고있는 속성값 프로퍼티로 정의
leeari95 added a commit that referenced this issue Jan 13, 2022
@leeari95
style: Asset 이미지 이름에 공백부분을 삭제하여 파일명 개선 #9
e3a8a37
llghdud921 added a commit that referenced this issue Jan 13, 2022
@llghdud921
refactor: 줄바꿈 컨벤션에 맞춰 개선 #9
aa1c79a
leeari95 added a commit that referenced this issue Jan 13, 2022
@leeari95
style: 메소드명 오타를 수정 #9
e8e87c6
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@llghdud921 llghdud921

@leeari95 leeari95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llghdud921 @leeari95